BUGFIX: document-node is redirected to the nearest parent on workspace change #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebobo
reviewed
Mar 6, 2024
|
I could reproduce the bug
Scenario 1 is working currently:
But scenario 2 fails currently:
|
mhsdesign
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on changing from a workspace to another one that didn't contain the current document-node, an exception would be triggered if no new document-node could be found a single level up in the node-tree.
This PR changes this behaviour to walk up the node-tree until a document-node can be found (going up to the site-node eventually) and sets the new document node to the first shared one that can be found in the rootline.